Improve the error handling to include the status code and error details #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls; handle fully-qualified ids in v5
ghost
assigned 
dustinmm80
suggested changes
Jan 5, 2018
There was a problem hiding this comment.
Code changes look good to me. Tests are passing.
I think we should start keeping a CHANGELOG for this library and versioning it. We can do this with a CHANGELOG.md file and git tags. This will make it easier for downstream tools to pull in specific versions, like the rest of our API clients.
Can you add a CHANGELOG file? It can start with v0.1.0 (pre-merge) and the result of this PR merge can be v0.1.1 or v0.2.0 - whatever you prefer.
|
Ok will do |
dustinmm80
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Conjur v5 provides error message details as JSON. Propagate these details when an exception occurs. Also, pass through the HTTP status code as an integer rather than a string embedded in the error message.
Also, in Conjur v5 the
idargument can be fully-qualified:account:kind:id. Update the API to permit fully qualified ids.Link to build in Jenkins (if appropriate)
https://jenkins.conjur.net/job/cyberark--conjur-api-go/job/feature%252Ferrors/
Questions:
Yes
No
The behavior of the Go client now better follows the REST API, by allowing fully-qualified ids and by returning the full error JSON.