64 Fix goconvey build issues
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgnn7
force-pushed
the
64-fix-goconvey-build-issues
branch
from
506ef41 to
07a4762
Compare
diverdane
previously approved these changes
Apr 27, 2020
|
@diverdane Good point - let me undo that part |
Goconvey depends on smartystreets/assertions which now requires v1.13 of Golang to even run. This change ensures that we have a minimum baseline to run the tests.
This upgrade was needed due to failures in goconvey when running the tests: smartystreets/goconvey#559 `go mod tidy` was used to clean thigs up in the modules metadata.
sgnn7
force-pushed
the
64-fix-goconvey-build-issues
branch
from
07a4762 to
54d205c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goconvey testing library that we use in this project depends on
smartystreets/assertionswhich recently started using API from Golang v1.13. This is a breaking change and has made our builds fail.This PR also upgrades
goconveyto latest version and hasgo mod tidyrunFixes #64