Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jenkins build: error when retrieving API key #110

Merged
merged 1 commit into from
May 13, 2022
Merged

Conversation

john-odonnell
Copy link
Contributor

What does this PR do?

Jenkins build was failing when retrieving user API keys when setting up test infra:

++ docker-compose exec -T conjur rails r 'print Credentials['\''cucumber:user:admin'\''].api_key'
+ api_key='[deprecated] Dry::Struct::Value is deprecated and will be removed in the next major version
/opt/conjur-server/app/domain/util/submodules.rb:7:in `const_get'\''
1h9spyz1y7jf2t2tfq8wx18jnmpravbbzvxfk1pt1svapqw3rasaae'

The deprecation message was being used in setup as part of the API key. While the source of this message needs to be addressed, the build can be fixed by retrieving the API keys with conjurctl instead of rails:

docker-compose exec -T conjur rails r "print Credentials['cucumber:user:admin'].api_key
 vv
docker-compose exec -T conjur conjurctl role retrieve-key cucumber:user:admin

What ticket does this PR close?

CyberArk internal issue link: ONYX-19910

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@john-odonnell john-odonnell requested a review from a team as a code owner May 12, 2022 18:11
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This seems like a cleaner way to go anyway.

@john-odonnell john-odonnell merged commit 620d5bc into main May 13, 2022
@john-odonnell john-odonnell deleted the ci-fix branch May 13, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants