-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ruby 3.0.2 #197
Support ruby 3.0.2 #197
Conversation
8c1c1b8
to
e3db215
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
Pay attention on backward compatibility issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code Climate has analyzed commit ce2dd19 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 83.9% (0.0% change). View more on Code Climate. |
Desired Outcome
Conjur-api-ruby is running on ruby-3.0.2.
Implemented Changes
Changed default ruby version to 3.0.2.
Changed necessary code segments to adjust for ruby-3.0.2:
nil
.URI.escape
is deprecated starting ruby-2.7, replaced withAddressable::URI.escape
Connected Issue/Story
CyberArk internal issue link: insert issue ID
Definition of Done
Tests are green with ruby-3.0.2.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security