Remove support for Ruby <2.7 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 7abf83d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 83.9% (0.0% change). View more on Code Climate. |
john-odonnell
approved these changes
Apr 28, 2022
| 1. Commit these changes - `Bump version to x.y.z` is an acceptable commit message - and open a PR | ||
| for review. Your PR should include updates to `lib/conjur-api/version.rb`, and |
There was a problem hiding this comment.
I think this entire Releasing section needs some more attention. The project was recently added to the new automated release flow, but this section was never updated to reflect that.
There was a problem hiding this comment.
Agreed. I just removed one inaccuracy but it definitely needs a larger overhaul.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
dev/Dockerfile.dev in conjur-api-ruby uses the ruby:2.5 base image. This image includes a number of known vulnerabilities. Update this to a later version (preferably one that matches our upgraded Ruby version everywhere else).
Implemented Changes
Connected Issue/Story
CyberArk internal issue link: ONYX-16435
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security