Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.16 #416

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Update to Go 1.16 #416

merged 1 commit into from
Oct 28, 2021

Conversation

szh
Copy link
Contributor

@szh szh commented Oct 27, 2021

Fixes build failing due to goconvey dependency change

The rest is copied from cyberark/secrets-provider-for-k8s#379:

Desired Outcome

Jenkins builds of Docker images do NOT fail with errors such as the following:

[2021-10-26T21:50:18.036Z] #21 1.547 package embed: unrecognized import path "embed": import path does not begin with hostname
[2021-10-26T21:50:26.134Z] #21 8.793 package io/fs: unrecognized import path "io/fs": import path does not begin with hostname
[2021-10-26T21:50:32.671Z] #21 ERROR: executor failed running [/bin/sh -c go get -u github.com/jstemmer/go-junit-report &&     go get github.com/smartystreets/goconvey]: exit code: 1

Implemented Changes

The version of Go used in our base Docker builder container is upgraded from Go v1.15 to Go v1.16.
This seems to eliminate the errors shown above.

Connected Issue/Story

Definition of Done

  • Jenkins builds run with no errors.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this Oct 27, 2021
@szh szh marked this pull request as ready for review October 27, 2021 21:01
@szh szh requested review from a team as code owners October 27, 2021 21:01
@szh szh requested a review from diverdane October 27, 2021 21:01
@szh szh force-pushed the fix-ci-go-errors branch from eb33d25 to 84a8d54 Compare October 28, 2021 13:39
@szh szh requested a review from doodlesbykumbi October 28, 2021 13:39
@szh szh force-pushed the fix-ci-go-errors branch 3 times, most recently from ff76baf to 63dab04 Compare October 28, 2021 14:09
Fixes build failing due to goconvey dependency change
@szh szh force-pushed the fix-ci-go-errors branch from 63dab04 to 78c8cc2 Compare October 28, 2021 14:10
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants