Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to version 0.23.0 #427

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Bump to version 0.23.0 #427

merged 1 commit into from
Jan 14, 2022

Conversation

tzheleznyak
Copy link
Contributor

Desired Outcome

Bump version to 0.23.0

@tzheleznyak tzheleznyak requested review from a team December 28, 2021 13:52
@tzheleznyak tzheleznyak requested a review from a team as a code owner December 28, 2021 13:52
Copy link
Contributor

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, thanks for bumping this for us. Just a couple of nits.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@szh
Copy link
Contributor

szh commented Jan 10, 2022

There are now breaking changes in this repo relating to the config refactoring (#425). Do we need to bump the major version?

@szh szh force-pushed the bump-version branch 3 times, most recently from f391187 to e05bf5a Compare January 13, 2022 18:56
@szh szh requested a review from diverdane January 13, 2022 18:57
@szh szh self-assigned this Jan 13, 2022
@szh szh force-pushed the bump-version branch 4 times, most recently from d2f116c to be029e5 Compare January 13, 2022 22:08
@szh szh force-pushed the bump-version branch 2 times, most recently from aa90761 to 427cad1 Compare January 14, 2022 14:25
diverdane
diverdane previously approved these changes Jan 14, 2022
Copy link
Contributor

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release date needs to be updated, but otherwise LGTM!!!
I clicked on Approve, hope this sticks after the date updating.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! Onward and upward!

@szh szh merged commit 510303b into master Jan 14, 2022
@szh szh deleted the bump-version branch January 14, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants