Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pattern check in schema validation for cert file path #434

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Jan 4, 2022

The conjur-config-cluster-prep Helm schema tests check that the certificate file path
has files or tests in the path. The file path is not restricted
to those directories and it should allow other paths.

Desired Outcome

The user should be able to specify an alternative path for the certificate file.
The files directory is only the default for the get-conjur-cert.sh
script but it is not required to be in this directory and the script is not required to be used,
this is only a helper script, the user can use an alternate method to get the cert.
Note that the certificate must be located inside the chart as Helm does not have access to
files outside the chart.

Implemented Changes

Removed the check for files in the schema verification.

Also added a change to bin/test-workflow/0_prep_env.sh
to use an existing UNIQUE_TEST_ID if it exists. This is only for debugging and allows
the user to set this variable and then run ./start -n and ./stop independently.
Jenkins will not have this set and should create a new unique id each time.

Connected Issue/Story

CyberArk internal issue link: ONYX-15540

Definition of Done

  • The certificate is not required to be in the files directory

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@rpothier rpothier requested review from a team as code owners January 4, 2022 20:23
@rpothier rpothier changed the title Remove schema check for cert file path Remove pattern check in schema for cert file path Jan 4, 2022
@rpothier rpothier force-pushed the 15540-helm-chart-bug branch 2 times, most recently from 36538eb to d86854a Compare January 4, 2022 23:19
@rpothier rpothier changed the title Remove pattern check in schema for cert file path Remove pattern check in schema validation for cert file path Jan 5, 2022
The Helm schema tests check that the cert file path
has `files` or `tests` in the path. The file path is not restricted
to those directories and it should allow other paths.
@rpothier rpothier force-pushed the 15540-helm-chart-bug branch from d86854a to 653ac1f Compare January 5, 2022 13:13
Copy link
Contributor

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants