Remove pattern check in schema validation for cert file path #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conjur-config-cluster-prep Helm schema tests check that the certificate file path
has
files
ortests
in the path. The file path is not restrictedto those directories and it should allow other paths.
Desired Outcome
The user should be able to specify an alternative path for the certificate file.
The files directory is only the default for the
get-conjur-cert.sh
script but it is not required to be in this directory and the script is not required to be used,
this is only a helper script, the user can use an alternate method to get the cert.
Note that the certificate must be located inside the chart as Helm does not have access to
files outside the chart.
Implemented Changes
Removed the check for
files
in the schema verification.Also added a change to bin/test-workflow/0_prep_env.sh
to use an existing UNIQUE_TEST_ID if it exists. This is only for debugging and allows
the user to set this variable and then run ./start -n and ./stop independently.
Jenkins will not have this set and should create a new unique id each time.
Connected Issue/Story
CyberArk internal issue link: ONYX-15540
Definition of Done
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security