Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update summon-sidecar E2E test to use namespace-label authn-k8s #482

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

john-odonnell
Copy link
Contributor

@john-odonnell john-odonnell commented Aug 10, 2022

Desired Outcome

Update our end-to-end test workflow to validate Authn-K8s namespace label selector restriction.

Implemented Changes

  • Update Cluster Prep Helm chart ClusterRole to provide get permission on namespaces.
  • The test-app-summon-sidecar host is configured with the namespace-label-selector resource restriction. If the summon-sidecar app succeeds, then namespace label-based Authn-K8s is functional.

Connected Issue/Story

N/A

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@john-odonnell john-odonnell marked this pull request as ready for review September 6, 2022 14:53
@john-odonnell john-odonnell requested a review from a team as a code owner September 6, 2022 14:53
Copy link
Contributor

@rpothier rpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just one minor comment.

@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [0.23.8] - 2022-08-31
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need the link to [0.23.8] defined at the bottom

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated.

@juniortaeza juniortaeza self-assigned this Sep 14, 2022
@juniortaeza juniortaeza self-requested a review September 14, 2022 14:34
@juniortaeza juniortaeza removed their assignment Sep 14, 2022
Copy link
Contributor

@juniortaeza juniortaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We tested the functionality of this as well and it looks great. Thank you!

### Changed
- Update Cluster Prep Helm chart to support namespace label-based authentication.
[cyberark/conjur-authn-k8s-client#482](https://github.com/cyberark/conjur-authn-k8s-client/pull/482)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants