Version info should be passed to the boot up log message #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpothier
force-pushed
the
fix-version
branch
16 times, most recently
from
ea73c3a to
20696b8
Compare
rpothier
force-pushed
the
fix-version
branch
2 times, most recently
from
1d05f99 to
7e1cb20
Compare
rpothier
force-pushed
the
fix-version
branch
5 times, most recently
from
55c0580 to
6301c42
Compare
szh
reviewed
Mar 15, 2023
13 tasks
rpothier
force-pushed
the
fix-version
branch
6 times, most recently
from
6d90281 to
551bc15
Compare
szh
reviewed
Mar 20, 2023
| @@ -125,7 +127,7 @@ LABEL description="The authentication client required to expose secrets from a C | |||
|
|
|||
| # =================== CONTAINER FOR HELM TEST =================== | |||
|
|
|||
| FROM golang:alpine as k8s-cluster-test | |||
| FROM golang:1.20-alpine as k8s-cluster-test | |||
There was a problem hiding this comment.
Why is this necessary? I don't think we're targeting Go 1.20 in any of the other images
There was a problem hiding this comment.
Also what's the simplest way to test this PR?
There was a problem hiding this comment.
Currently golang:alpine and golang:1.20-alpine are the same image, so there is currently no change to the image.
#502 updated golang in the Dockerfiles to 1.19, a fixed version, and golang:alpine will change over time.
We could use 1.19 however that version is older and that won't help the security issues.
This change is not needed for the version info.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
conjur-authn-k8s-client release artifact reports wrong version
Implemented Changes
The Version from the automated release is used in the startup logs.
Also updated the changelog as the next version should be version 0.24.1.
Connected Issue/Story
CyberArk internal issue ID: CNJR-770
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security