Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container security settings #518

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Update container security settings #518

merged 1 commit into from
Jun 12, 2023

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Jun 12, 2023

Desired Outcome

Container manifests should not have Snyk issues.

Implemented Changes

Updated the container security settings.
Not all Snyk issues can be addressed as these are manifests for CI and require some of the setting.
Other settings line liveness probes are not needed for CI.

The other Synk issues were addressed in PR 516

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: CONJSE-1745

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@rpothier rpothier marked this pull request as ready for review June 12, 2023 20:06
@rpothier rpothier requested a review from a team as a code owner June 12, 2023 20:06
Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@rpothier rpothier merged commit 452ae22 into master Jun 12, 2023
@rpothier rpothier deleted the snyk-issues branch June 12, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants