Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strategy for publishing images #42

Closed
2 tasks done
izgeri opened this issue Nov 5, 2020 · 1 comment · Fixed by #46
Closed
2 tasks done

Update strategy for publishing images #42

izgeri opened this issue Nov 5, 2020 · 1 comment · Fixed by #46
Assignees

Comments

@izgeri
Copy link
Contributor

izgeri commented Nov 5, 2020

Motivation

At current, we publish 1.14-latest and latest tags for the RH UBI-based Nginx image. RH requires images use a "good tag", however, and these don't work:

  1. Image should include a tag, other than latest

Test name: good_tags
Why? So the image can be uniquely identified
How? Use the docker tag command to add a tag. A common tag is the image version. The latest tag will be automatically added to the most recent image, so it should not be set explicitly.

Proposed Implementation

We are going to move to versioning this project and publishing public images only on new tags / project releases.

To accomplish this, we will:

  • Add a VERSION file to the project
  • Set the initial VERSION to 1.0.0
  • Update the pipeline so that on pipeline builds, images are only published to the internal Docker registry
  • Update the pipeline so that on v1.x.y tags, the following image tags are published to DockerHub: latest, 1, 1.x, 1.x.y. This will also involve removing the PUBLISH_DOCKERHUB build param, which will no longer be needed.
  • Once these changes are merged, we'll tag 1.0.0 and publish the new images.
  • Update the Conjur project to use the 1.x.y tag to build Conjur.

AC:

  • Determine a strategy for adding unique tags for images (potentially don't push on every nightly build)
  • Implement the new strategy for publishing images
@izgeri
Copy link
Contributor Author

izgeri commented Nov 9, 2020

Note: the build is also broken on this issue, as RH container registry only allows you to push each tag once. It's now failing on the error:

denied: The image tag you are pushing already exists. Please re-tag the image.

@izgeri izgeri self-assigned this Nov 24, 2020
@izgeri izgeri changed the title Update strategy for publishing Nginx image Update strategy for publishing images Dec 7, 2020
izgeri pushed a commit to cyberark/conjur that referenced this issue Dec 15, 2020
In cyberark/conjur-base-image#42 we updated the Conjur Base Image project to
use semantic version-based tags. In this commit, we update the test / dev images
to use the "latest" versions while the Conjur images will be built from a
pinned base image version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant