Remove netgo tag to fix Windows hosts file bug

cyberark · Apr 18, 2023 · c6fb44a · c6fb44a
1 parent 8d2f3ae
commit c6fb44a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.goreleaser.yml b/.goreleaser.yml
@@ -14,8 +14,13 @@ builds:
   # Tag 'netgo' is a Go build tag that ensures a pure Go networking stack
   # in the resulting binary instead of using the default host's stack to
   # ensure a fully static artifact that has no dependencies.
+  # However, netgo on Windows has a bug that prevents it from using the
+  # machine's hosts file for DNS resolution. Therefore this tag must be
+  # omitted on Windows until the bug is fixed. See
+  # https://github.com/golang/go/issues/57757 and internal ticket
+  # CNJR-904 for more information.
   flags:
-  - -tags=netgo
+  - -tags={{ if ne .Os "windows" }}netgo{{ end }}
   - -a
   goos:
   - linux

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [8.0.7] - 2023-04-17
 
+### Fixed
+
+- Fixed not using hosts file on Windows
+  [cyberark/conjur-cli-go#121](https://github.com/cyberark/conjur-cli-go/pull/121)
+
 ## [8.0.6] - 2023-04-17
 
 ### Fixed