Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conjur-api-go for Hostfactory #104

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Update conjur-api-go for Hostfactory #104

merged 1 commit into from
Feb 15, 2023

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Feb 15, 2023

Desired Outcome

Hostfactory should allow partially qualifies hostfactory name.

Implemented Changes

Pull in the latest conjur-api-go.
Update the help messsage .

Connected Issue/Story

CyberArk internal issue ID:N/A

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@rpothier rpothier force-pushed the fix-hostfactory branch 2 times, most recently from 49367fe to 1f62c53 Compare February 15, 2023 13:00
@rpothier rpothier force-pushed the fix-hostfactory branch 3 times, most recently from 13815e2 to 73838ee Compare February 15, 2023 15:04
@rpothier rpothier marked this pull request as ready for review February 15, 2023 15:23
@rpothier rpothier requested a review from a team as a code owner February 15, 2023 15:23
@codeclimate
Copy link

codeclimate bot commented Feb 15, 2023

Code Climate has analyzed commit fb55bff and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 80.7% (0.0% change).

View more on Code Climate.

@rpothier rpothier changed the title Update hostfactory help hessage Update conjur-api-go for Hostfactory Feb 15, 2023
@jtuttle jtuttle merged commit 2a14e75 into master Feb 15, 2023
@jtuttle jtuttle deleted the fix-hostfactory branch February 15, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants