Upgrade API key rotation to support fully- and partially-qualified IDs #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-odonnell
force-pushed
the
rotate-api-key-fully-qualified-support
branch
2 times, most recently
from
9418900 to
9f89c60
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
john-odonnell
force-pushed
the
rotate-api-key-fully-qualified-support
branch
2 times, most recently
from
d47333f to
dd6c1a4
Compare
| @@ -155,3 +156,10 @@ func assertLogoutCmd(t *testing.T, err error, stdOut string, stdErr string) { | |||
| assert.Contains(t, stdOut, "Logged out\n") | |||
| assert.Equal(t, "", stdErr) | |||
| } | |||
|
|
|||
| func assertAPIKeyRotationCmd(t *testing.T, err error, stdOut string, stdErr string, priorAPIKey string) { | |||
There was a problem hiding this comment.
Function assertAPIKeyRotationCmd has 5 arguments (exceeds 4 allowed). Consider refactoring.
john-odonnell
force-pushed
the
rotate-api-key-fully-qualified-support
branch
from
dd6c1a4 to
0df6edd
Compare
|
Code Climate has analyzed commit 0df6edd and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 80.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Allow
conjur [user|host] rotate-api-keyto accept fully- and partially-qualified IDs.Implemented Changes
Use the latest version of
conjur-api-go, which allowsRotate[User|Host]APIKey()functions to accept both fully- and partially-qualified role IDs.Add integration test cases to ensure the CLI can rotate a [user|host]'s role given an ID of varying degrees of qualification.
Connected Issue/Story
N/A
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security