Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hostfactory to create tokens with a CIDR subnet #113

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Feb 23, 2023

Desired Outcome

Hostfactory should allow a subnet on the cidrs

Implemented Changes

The Golang Cobra CLI checks to verify the IP address, but this
is too restrictive as we want to allow an IP address with no subnet and also an IP address with a subnet.
If there is no subnet supplied by the user, it defaults to /32.

Removed the use of IPSliceP() and changed to just a plain string.
The CLI will no longer validate the IP address.

Connected Issue/Story

CyberArk internal issue ID: [ONYX-33513]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@rpothier rpothier self-assigned this Feb 23, 2023
@rpothier rpothier force-pushed the allow-hostfactory-tokens-with-subnet branch from 974345c to e843576 Compare February 23, 2023 18:33
CHANGELOG.md Show resolved Hide resolved
@rpothier rpothier marked this pull request as ready for review February 23, 2023 18:56
@rpothier rpothier requested a review from a team as a code owner February 23, 2023 18:56
@rpothier rpothier force-pushed the allow-hostfactory-tokens-with-subnet branch from e843576 to 678e259 Compare February 23, 2023 19:02
@rpothier rpothier force-pushed the allow-hostfactory-tokens-with-subnet branch from 678e259 to 8e28875 Compare February 23, 2023 19:37
@codeclimate
Copy link

codeclimate bot commented Feb 23, 2023

Code Climate has analyzed commit 8e28875 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 80.8% (0.0% change).

View more on Code Climate.

@rpothier rpothier marked this pull request as draft February 23, 2023 20:22
@rpothier rpothier marked this pull request as ready for review February 23, 2023 20:30
@szh szh self-requested a review February 23, 2023 21:05
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpothier rpothier merged commit 906b8e2 into master Feb 23, 2023
@rpothier rpothier deleted the allow-hostfactory-tokens-with-subnet branch February 23, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants