Allow hostfactory to create tokens with a CIDR subnet #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Hostfactory should allow a subnet on the cidrs
Implemented Changes
The Golang Cobra CLI checks to verify the IP address, but this
is too restrictive as we want to allow an IP address with no subnet and also an IP address with a subnet.
If there is no subnet supplied by the user, it defaults to /32.
Removed the use of IPSliceP() and changed to just a plain string.
The CLI will no longer validate the IP address.
Connected Issue/Story
CyberArk internal issue ID: [ONYX-33513]
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security