Improve error message when using self-signed certificate #119
Conversation
szh
force-pushed
the
self-signed-msg
branch
3 times, most recently
from
38458ed to
925bb0a
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 2c6bf5b and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 81.0% (0.0% change). View more on Code Climate. |
| - ../conf/:/etc/nginx/conf.d/:ro | ||
| - ../conf/tls/:/etc/nginx/tls/:ro | ||
| - ./conf/:/etc/nginx/conf.d/:ro | ||
| - ./conf/tls/:/etc/nginx/tls/:ro |
There was a problem hiding this comment.
Just to confirm this is to capture the idea that this docker-compose environment is only ever run with the working directory set to where the docker-compose.yml file is ?
There was a problem hiding this comment.
Yeah. This is used in the CI script and this path was incorrect to begin with from what I can tell. I only realized it when I tried to use the proxy service in the course of testing.
Desired Outcome
Conjur CLI message when not using --self-signed with self signed cert should be improved
Implemented Changes
initcommand, if there's an error retrieving or validating the server certificate, and the --self-signed flag is not provided, print "If you're attempting to use a self-signed certificate, re-run the init command with the--self-signedflag"Connected Issue/Story
CyberArk internal issue ID: CNJR-506
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security