This repository has been archived by the owner on Jan 9, 2021. It is now read-only.
Adds build test and publishing instructions #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diverdane
force-pushed
the
track_tags
branch
3 times, most recently
from
ea77551 to
42b03ce
Compare
sgnn7
suggested changes
Mar 19, 2020
There was a problem hiding this comment.
@diverdane Great job on this - left some comments but most of them are nits!
This change adds the following changes: - Adds detailed instructions for building, testing, releasing, and publishing to CONTRIBUTING.md - Adds a mechanism for contributors outside of CyberArk to build and test new versions of the Marketplace without requiring access to the conjur-cloud-launcher-onboard GCP project. - Updates the Google Marketplace schema we use to Version 2.
sgnn7
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
@diverdane Great work and LGTM! Hopefully the full semver (1.4.0) is what they want vs the track (1.4) 🤞
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the following changes:
publishing to CONTRIBUTING.md
test new versions of the Marketplace without requiring access to the
conjur-cloud-launcher-onboard GCP project.