Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated request body on secret creation #187

Merged
merged 1 commit into from
May 7, 2021
Merged

Conversation

telday
Copy link
Contributor

@telday telday commented May 5, 2021

What does this PR do?

This allows the java client to properly set a secret in the generated client. Currently it is unable to properly handle the format: binary type for strings.

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@telday telday requested a review from a team as a code owner May 5, 2021 14:58
@telday telday force-pushed the update-request-body branch from 62018e1 to 2074abe Compare May 5, 2021 14:58
@telday telday mentioned this pull request May 5, 2021
17 tasks
@telday telday force-pushed the update-request-body branch from 2074abe to 1516fb9 Compare May 5, 2021 15:04
This allows the java client to properly set a secret in
the generated client. Currently it is unable to properly
handle the `format: binary` type for strings.
@telday telday force-pushed the update-request-body branch from 1516fb9 to eef0c49 Compare May 7, 2021 13:54
@telday telday merged commit 96bda52 into main May 7, 2021
@telday telday deleted the update-request-body branch May 7, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants