Update security preferences #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telday
force-pushed
the
update-security-list
branch
from
ff4b8ef to
e3ae4fd
Compare
If an empty list is not specified for the `security` field then some utilities will automatically assume ALL authentication types are supposed to be used. Obviously this causes issues.
telday
force-pushed
the
update-security-list
branch
from
e3ae4fd to
f2f7526
Compare
john-odonnell
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
LGTM. Noticed that the last few PRs experience API contract test flakiness, so I filed #197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Need to specify that no authentication method should be used when using some authentication methods. If nothing is specified for the field then some utilities assume all of them should be used. This causes issues.
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or