This repository has been archived by the owner on Feb 25, 2021. It is now read-only.
22 add types to relativepathresolver #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should add tests cases for grant/revoke and permit/deny with absolute and relative paths in the test fixtures: https://github.com/cyberark/conjur-policy-parser/tree/master/spec/resolver-fixtures There should at least be test case that would fail without this before making the change. |
|
Yes, I will add a test case. This PR was put on hold until I update master to match the current tag (v3.0.4) |
h-artzi
force-pushed
the
22-add-types-to-relativepathresolver
branch
3 times, most recently
from
3812964 to
9385661
Compare
h-artzi
force-pushed
the
22-add-types-to-relativepathresolver
branch
from
9385661 to
ca4b82b
Compare
micahlee
reviewed
Jun 29, 2020
| - !revoke | ||
| member: !member | ||
| account: the-account | ||
| id: myapp/../the-group |
There was a problem hiding this comment.
Did you expect this .. to be expanded/resolved?
There was a problem hiding this comment.
I did not, I forgot to change this from an earlier test I was running.
micahlee
reviewed
Jun 29, 2020
lib/conjur/policy/resolver.rb
Outdated
| Array(record.member).each do |member| | ||
| member.role.id = absolute_path_of(member.role.id) | ||
| # Member has either role.id or id |
There was a problem hiding this comment.
This comment should be expanded a bit more. It's not clear to me what each of these cases means.
h-artzi
force-pushed
the
22-add-types-to-relativepathresolver
branch
from
ca4b82b to
adb3738
Compare
This should fail when running `./test.sh` because the fix has not been implemented yet.
h-artzi
force-pushed
the
22-add-types-to-relativepathresolver
branch
from
adb3738 to
f832ca2
Compare
jtuttle
approved these changes
Jul 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #22
I was unsure regarding the relative paths for members in
revokeandgrantstatements. It seems that members either have arole.idor anid. So currently, I transform both of those into relative paths. (Not sure if that was the right decision)The next step is to bump the version!