Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Upgrade rack from 2.2.6.3 to 2.2.6.4 #323

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Upgrade rack from 2.2.6.3 to 2.2.6.4 #323

merged 2 commits into from
Apr 4, 2023

Conversation

juniortaeza
Copy link
Contributor

@juniortaeza juniortaeza commented Mar 21, 2023

No description provided.

@juniortaeza juniortaeza requested a review from a team as a code owner March 21, 2023 16:08
Copy link
Contributor

@andytinkham andytinkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested one change in the CHANGELOG. What do you think about rolling in the dependabot changes from #321 and #322 as well. Looks like those PRs built, so it would just be make the same changes in the PR & update CHANGELOG & NOTICES to include the new versions there as well.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@andytinkham andytinkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small change to the CHANGELOG and it's good to go. Thanks, @juniortaeza!

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andytinkham andytinkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @juniortaeza! Sorry for the delay on this

@juniortaeza juniortaeza merged commit 5cb9642 into main Apr 4, 2023
@juniortaeza juniortaeza deleted the upgrade-branch branch April 4, 2023 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants