Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled authenticators can be configured using configuration file #2173

Closed
jtuttle opened this issue May 14, 2021 · 2 comments · Fixed by #2217
Closed

Enabled authenticators can be configured using configuration file #2173

jtuttle opened this issue May 14, 2021 · 2 comments · Fixed by #2217

Comments

@jtuttle
Copy link
Contributor

jtuttle commented May 14, 2021

Add an :authenticators attribute to the Conjur::ConjurConfig object. It should default to an empty string and should be validated to ensure it's a comma-separated list of strings starting w/ "authn-".

Update Authentication::InstalledAuthenticators to use read the authenticators attribute from ConjurConfig instead of the CONJUR_AUTHENTICATORS environment variable.

Tests

  • update spec / integration tests for Authentication::InstalledAuthenticators
@kvanblarcum
Copy link

I am confused by the wording within this story. With Trusted Proxy, the precedence was established to be CONJUR env variable >>> config file >>> old env variable. But the way this story is worded, it appears that the config file will be given a higher precedence. (read the authenticator attribute from conjurconfig instead of the conjur_auth env variable). I think we need to be consistent.

h-artzi added a commit that referenced this issue May 24, 2021
h-artzi added a commit that referenced this issue May 25, 2021
@h-artzi
Copy link
Contributor

h-artzi commented May 25, 2021

CONJUR_AUTHENTICATORS env variable >> config file >> database configuration

h-artzi added a commit that referenced this issue May 25, 2021
h-artzi added a commit that referenced this issue May 25, 2021
h-artzi added a commit that referenced this issue May 26, 2021
h-artzi added a commit that referenced this issue May 26, 2021
h-artzi added a commit that referenced this issue May 26, 2021
h-artzi added a commit that referenced this issue May 27, 2021
h-artzi added a commit that referenced this issue May 27, 2021
h-artzi added a commit that referenced this issue May 27, 2021
h-artzi added a commit that referenced this issue May 27, 2021
h-artzi added a commit that referenced this issue May 27, 2021
h-artzi added a commit that referenced this issue May 27, 2021
h-artzi added a commit that referenced this issue May 27, 2021
h-artzi added a commit that referenced this issue May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants