add ENV variable that reads from VERSION file #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-artzi
force-pushed
the
update-version-on-status-page
branch
from
94f95f1 to
4de379d
Compare
micahlee
reviewed
Mar 24, 2020
h-artzi
force-pushed
the
update-version-on-status-page
branch
3 times, most recently
from
405a938 to
777dcfe
Compare
The naming was chosen due to the fact that `CONJUR_VERSION` interferes with current tests
h-artzi
force-pushed
the
update-version-on-status-page
branch
from
777dcfe to
16ba9af
Compare
|
I just kept them separate for readability but have no problem combining them |
h-artzi
changed the title
|
Code Climate has analyzed commit 708c5d9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 89.4% (0.0% change). View more on Code Climate. |
micahlee
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It displays the correct version on the status page. This version number is retrieved from the VERSION file
How to Test
./build.shcd dev./startconjurctl serverwithin the containerScreen Shot
What ticket does this PR close?
Connected to #1438
Checklists
Test coverage
Follow-on issues