Remove the ActionDispatch::RemoteIp middleware #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This middleware provides additional logic for selecting the client IP address in Conjur, and stores the client IP in `request.remote_ip`. This can sometimes be different than the client IP determined by Rack in `request.ip`. We use `request.ip` for audit and CIDR restrictions. However, Rails uses `request.remote_ip` in the request log. In order to make the request log match the audit log and network restrictions, we remove this middleware. This causes `request.remote_ip` to fallback to the value in `request.ip`.
|
Code Climate has analyzed commit c4ff54c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.2% (0.0% change). View more on Code Climate. |
|
LGTM! |
h-artzi
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes
ActionDispatch::RemoteIPfrom the Conjur Rack middleware.This middlewareprovides additional logic for selecting the client IP address in Conjur,
and stores the client IP in
request.remote_ip. This can sometimes be different thanthe client IP determined by Rack in
request.ip.We use
request.ipfor audit and CIDR restrictions. However, Rails usesrequest.remote_ipin the request log.In order to make the request log match the audit log and network restrictions, we remove this middleware. This causes
request.remote_ipto fallback to the value inrequest.ip.What ticket does this PR close?
Connected to #1719
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or