Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ruby version to 2.5.8 #1906

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Update Ruby version to 2.5.8 #1906

merged 1 commit into from
Oct 26, 2020

Conversation

micahlee
Copy link
Contributor

@micahlee micahlee commented Oct 26, 2020 •
edited
Loading

What does this PR do?

  • What's changed? Why were these changes made?

This PR updates the expected Ruby version to match what is now included in the base image (2.5.8).

What ticket does this PR close?

Connected to cyberark/conjur-base-image#33

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require additional or updated tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@micahlee micahlee changed the title Update ruby version Update Ruby version to 2.5.8 Oct 26, 2020
@micahlee
Bump expected Ruby version to 2.5.8
d4c0893 
This matches the updated  Ruby version from the
base image.
@micahlee micahlee force-pushed the update-ruby-version branch from 8b21653 to d4c0893 Compare October 26, 2020 14:31
@codeclimate
Copy link

codeclimate bot commented Oct 26, 2020

Code Climate has analyzed commit d4c0893 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.0% (0.0% change).

View more on Code Climate.

@micahlee micahlee marked this pull request as ready for review October 26, 2020 15:21
@micahlee micahlee requested a review from a team as a code owner October 26, 2020 15:21
@jtuttle jtuttle merged commit 8bfe9c7 into master Oct 26, 2020
@jtuttle jtuttle deleted the update-ruby-version branch October 26, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtuttle jtuttle jtuttle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micahlee @jtuttle