Rotating the API key of an nonexistent role returns Error #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-odonnell
force-pushed
the
rotate_api_key_tests
branch
2 times, most recently
from
cc59a98 to
0e260ef
Compare
john-odonnell
changed the title
diverdane
reviewed
Nov 4, 2020
There was a problem hiding this comment.
@john-odonnell this looks pretty good to me, esp. after your explanations in chat.
A couple of minor editorial questions/suggestions.
john-odonnell
force-pushed
the
rotate_api_key_tests
branch
2 times, most recently
from
b982cda to
536daa8
Compare
This fixes a bug where a user rotating a nonexistent role's API key with basic auth would receive a successful status code implying that the nonexistent role's key was rotated. In reality, the user was rotating their own API key. The action of rotating a nonexistent user's API key is now rejected with a 401 Unauthorized status code. Adds test cases to confirm.
john-odonnell
force-pushed
the
rotate_api_key_tests
branch
from
536daa8 to
ce0145d
Compare
|
Code Climate has analyzed commit ce0145d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 87.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug where a user rotating a nonexistent role's API key with basic auth would
receive a successful status code implying that the nonexistent role's key was rotated. In
reality, the user was rotating their own API key. The action of rotating a nonexistent user's
API key is now rejected with a 401 Unauthorized status code. Adds test cases to confirm.
What ticket does this PR close?
Resolves #1914
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or