update sql function annotation_update_textsearch to check for resourc… #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-artzi
force-pushed
the
update-resource_update_textsearch-function
branch
5 times, most recently
from
e27a15a to
3ce56d8
Compare
…e_id existance Without checking if resource_id existance, queries can fail due to a foreign key constraint. Related post: https://discuss.cyberarkcommons.org/t/database-error-after-backup-restore/474/11
h-artzi
force-pushed
the
update-resource_update_textsearch-function
branch
from
3ce56d8 to
38c8e5e
Compare
|
Code Climate has analyzed commit 38c8e5e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.4%. View more on Code Climate. |
|
would this change merit an update to UPGRADING.md? |
6 tasks
|
Superseded by #1999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without checking if resource_id existence, queries can fail due to a foreign key constraint.
Related post: https://discuss.cyberarkcommons.org/t/database-error-after-backup-restore/474/11
What does this PR do?
The following SQL function
annotation_update_textsearchis updated to ensure theresource_idexists during update/deletion. If it doesn't an appropriate log message is recorded. This ensures we do not receive the 500 error highlighted in the issue.What ticket does this PR close?
Resolves #1948
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or