Change return code on fail to encode batch secrets #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telday
force-pushed
the
change-return-code
branch
from
55fa376 to
9c182b2
Compare
6 tasks
telday
force-pushed
the
change-return-code
branch
from
9c182b2 to
57adba4
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
izgeri
reviewed
Apr 26, 2021
telday
force-pushed
the
change-return-code
branch
from
57adba4 to
8e5d2ac
Compare
jonahx
previously approved these changes
Apr 27, 2021
telday
force-pushed
the
change-return-code
branch
2 times, most recently
from
c115f9b to
44680ba
Compare
Now when Conjur attempts to encode a batch secrets response into JSON format and encounters an encoding error it will return a 406 status code to the user. This indicates that The given `Accept-Encoding` header is not valid for the retrieved values.
telday
force-pushed
the
change-return-code
branch
from
44680ba to
05230f1
Compare
|
Code Climate has analyzed commit 05230f1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 89.1%. View more on Code Climate. |
jonahx
approved these changes
Apr 28, 2021
6 tasks
|
@alexkalish it only applies to the custom error we added for the batch secrets request endpoint in #1989 (which resolved #1962) we previously added the exception but we didn't rescue it here to return a non-500 error code; this PR fixes that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Now when Conjur attempts to encode a batch secrets
response into JSON format and encounters an encoding
error it will return a 406 status code to the user.
This indicates that The given
Accept-Encodingheaderis not valid for the retrieved values.
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, orAPI Changes