Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rails to 5.2.6 #2150

Merged
merged 1 commit into from
May 6, 2021
Merged

Update rails to 5.2.6 #2150

merged 1 commit into from
May 6, 2021

Conversation

andytinkham
Copy link
Contributor

@andytinkham andytinkham commented May 6, 2021

Signed-off-by: Andy Tinkham [email protected]

What does this PR do?

What ticket does this PR close?

Resolves #2149

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

API Changes

  • The OpenAPI spec has been updated to meet new API changes (or an issue has been opened), or
  • The changes in this PR do not affect the Conjur API

@andytinkham andytinkham requested a review from a team as a code owner May 6, 2021 18:39
@andytinkham andytinkham force-pushed the rails-update-5.2.6 branch from 903ed8d to e3a6c31 Compare May 6, 2021 19:07
@@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Security
- Upgrade Rails to 5.2.5 to resolve CVE-2021-22885
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces

@@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Security
- Upgrade Rails to 5.2.5 to resolve CVE-2021-22885
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

@codeclimate
Copy link

codeclimate bot commented May 6, 2021

Code Climate has analyzed commit e3a6c31 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 3

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.1% (0.0% change).

View more on Code Climate.

@andytinkham andytinkham changed the title Update rails to 5.2.6 and remove debase Update rails to 5.2.6 May 6, 2021
@jonahx jonahx merged commit dcf418d into master May 6, 2021
@jonahx jonahx deleted the rails-update-5.2.6 branch May 6, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Rails to 5.2.6
2 participants