ONYX-10520 : Add CreateConstraintsFromPolicy Command Class #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzheleznyak
force-pushed
the
AddCreateConstrainsFromPolicy
branch
from
1e111de to
4edd308
Compare
nessiLahav
reviewed
Jul 21, 2021
app/domain/authentication/authn_jwt/restriction_validation/create_constraints_from_policy.rb
Outdated
Show resolved
Hide resolved
nessiLahav
reviewed
Jul 21, 2021
app/domain/authentication/authn_jwt/restriction_validation/create_constraints_from_policy.rb
Outdated
Show resolved
Hide resolved
nessiLahav
reviewed
Jul 21, 2021
app/domain/authentication/authn_jwt/restriction_validation/create_constraints_from_policy.rb
Outdated
Show resolved
Hide resolved
nessiLahav
reviewed
Jul 21, 2021
app/domain/authentication/authn_jwt/restriction_validation/create_constraints_from_policy.rb
Outdated
Show resolved
Hide resolved
nessiLahav
reviewed
Jul 21, 2021
app/domain/authentication/authn_jwt/restriction_validation/create_constraints_from_policy.rb
Outdated
Show resolved
Hide resolved
nessiLahav
reviewed
Jul 21, 2021
app/domain/authentication/authn_jwt/restriction_validation/create_constraints_from_policy.rb
Outdated
Show resolved
Hide resolved
nessiLahav
reviewed
Jul 21, 2021
app/domain/authentication/authn_jwt/restriction_validation/create_constraints_from_policy.rb
Outdated
Show resolved
Hide resolved
nessiLahav
reviewed
Jul 21, 2021
app/domain/authentication/authn_jwt/vendor_configurations/configuration_jwt_generic_vendor.rb
Outdated
Show resolved
Hide resolved
nessiLahav
reviewed
Jul 21, 2021
| @@ -658,6 +658,16 @@ module AuthnJwt | |||
| msg: "Successfully fetched mapping claims '{0-mapping-claims}'", | |||
| code: "CONJ00130I" | |||
| ) | |||
|
|
|||
| CreateContraintsFromPolicy = ::Util::TrackableLogMessageClass.new( | |||
| msg: "Creating constraints from policy...", | |||
There was a problem hiding this comment.
challenge the "from policy" term
There was a problem hiding this comment.
@hilagross @shulifink
We did agree we call it from policy in all places not?
nessiLahav
reviewed
Jul 21, 2021
tzheleznyak
commented
Jul 21, 2021
benoaviram
reviewed
Jul 21, 2021
app/domain/authentication/authn_jwt/restriction_validation/create_constraints_from_policy.rb
Outdated
Show resolved
Hide resolved
tzheleznyak
force-pushed
the
AddCreateConstrainsFromPolicy
branch
3 times, most recently
from
80a3a3c to
60c21d9
Compare
sashaCher
reviewed
Jul 21, 2021
eladkug
reviewed
Jul 21, 2021
| And I successfully set authn-jwt jwks-uri variable with value of "myJWKs.json" endpoint | ||
|
|
||
| Scenario: ONYX-10471 - Mandatory Claims Without Claims Mapping. Single mandatory claim - 200 OK | ||
| Given I have a "variable" resource called "test-variable" |
There was a problem hiding this comment.
why its not part of your policy?
eladkug
reviewed
Jul 21, 2021
| CONJ00037E Missing value for resource: cucumber:variable:conjur/authn-jwt/raw/mandatory-claims | ||
| """ | ||
|
|
||
| Scenario: ONYX-10891 - Complex Case - Adding Mandatory Claim after host configuration |
There was a problem hiding this comment.
Its not clear the full scenario you run here.
You run three when but by the scenario you run only two.
You run basic scenario(pass), add mandatory claim (fail) update the policy (pass) the last when is not clear for me
There was a problem hiding this comment.
Talked about it
tzheleznyak
force-pushed
the
AddCreateConstrainsFromPolicy
branch
2 times, most recently
from
6bf01f7 to
89d5e75
Compare
tzheleznyak
force-pushed
the
AddCreateConstrainsFromPolicy
branch
from
89d5e75 to
cb34d8b
Compare
tzheleznyak
changed the base branch from
master
to
jwt-feature-mandatory-and-mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add mandatory claims support to JWTGenericVendorConfiguration
What ticket does this PR close?
ONYX-10520
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, orAPI Changes