Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONYX-13812: Claim Validation - Cucumber Integration Tests #2408

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

semyon-estrin
Copy link
Contributor

Desired Outcome

Test new constrains of input for Claim Aliases. Related to #2403.

Implemented Changes

Added 4 Integration tests:

  • Authn JWT - Aliased nested annotation- 200 OK
  • Authn JWT - Aliased nested annotation- 401 Error
  • Authn JWT - Aliased and Enforced nested annotation- 200 OK
  • Authn JWT - Bad formated claim aliase- 401 Error

Connected Issue/Story

Resolved CyberArk internal issue link: 13812

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@semyon-estrin semyon-estrin requested a review from a team as a code owner November 3, 2021 13:21
@semyon-estrin semyon-estrin self-assigned this Nov 3, 2021
Copy link
Contributor

@tzheleznyak tzheleznyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@codeclimate
Copy link

codeclimate bot commented Nov 3, 2021

Code Climate has analyzed commit 42d0b61 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.9% (0.0% change).

View more on Code Climate.

@semyon-estrin semyon-estrin merged commit 92ad037 into master Nov 3, 2021
@semyon-estrin semyon-estrin deleted the nested-claims-input-valid branch November 3, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants