authn-jwt jwks-uri with ca-cert integration tests
#2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
tzheleznyak
reviewed
Jan 3, 2022
| And the HTTP response content type is "application/json" | ||
| And the authenticator status check succeeds | ||
|
|
||
| Scenario Outline: ONYX-15313/6: Self-signed jwks-uri with ca-cert contains bundle includes the valid certificate |
There was a problem hiding this comment.
This outline combines two similar tests one for self-signed use case and one for chained
sashaCher
force-pushed
the
authn-jwt-ca-cert-infra
branch
from
2fa00fd to
092548a
Compare
sashaCher
changed the title
authn-jwt jwks-uri with ca-cert integration testsauthn-jwt jwks-uri with ca-cert integration tests
sashaCher
force-pushed
the
authn-jwt-ca-cert-infra
branch
from
092548a to
ce063c0
Compare
The server name exposes HTTPS endpoint with static chained certificate
Skip tests that's waiting for feature implementation
sashaCher
force-pushed
the
authn-jwt-ca-cert-infra
branch
from
ce063c0 to
87f41ea
Compare
| @@ -0,0 +1,14 @@ | |||
| Given(/^I fetch root certificate from https:\/\/([^"]*) endpoint as "([^"]*)"$/) do |hostname, key| | |||
There was a problem hiding this comment.
Use %r around regular expression.
| fetch_and_store_root_certificate(hostname: hostname, key: key) | ||
| end | ||
|
|
||
| Given(/^I successfully set authn\-jwt "([^"]*)" variable value to the "([^"]*)" certificate$/) do |variable, key| |
There was a problem hiding this comment.
Redundant escape inside regexp literal
| @certs ||= {} | ||
| end | ||
|
|
||
| def get_certificate_chain(connect_hostname) |
There was a problem hiding this comment.
CertsHelper#get_certificate_chain doesn't depend on instance state (maybe move it to another class?)
|
|
||
| ```bash | ||
| cp ./certificates/nodes/chained.mycompany.local/chained.mycompany.local.cert.pem ./ | ||
| cp ./certificates/nodes/chained.mycompany.local/chained.mycompany.local.key.pem ./ |
| full chain bundle | ||
|
|
||
| ```bash | ||
| cp ./certificates/nodes/chained.mycompany.local/chained.mycompany.local.cert.pem ./ |
|
Code Climate has analyzed commit 87f41ea and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Test recently added
ca-certvariable ofauthn-jwtImplemented Changes
mycompany.localthat's using the certificate chainjwksserver is already using self signedConnected Issue/Story
ONYX-15511
Definition of Done
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security