Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix - IAM Authn Fails #2493

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Bug Fix - IAM Authn Fails #2493

merged 1 commit into from
Feb 14, 2022

Conversation

semyon-estrin
Copy link
Contributor

@semyon-estrin semyon-estrin commented Feb 14, 2022

Desired Outcome

As part of Ruby 3 support, rexml gem was isolated in :test :development gem environments.
This gem is required in production for IAM authentication (at least).
The Root cause for the separation is that Ruby 3 gem is external, comparing to 2.5 where it comes with the Ruby itself.
Documentation for this separation.

This bug reconstructs only during manual tests, automatic tests do not exist for IAM authenticator.

Implemented Changes

Move rexml in Gemfile to production environment.

Definition of Done

Authentication succeeds in prod environment - reconstructs in manual tests only.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@semyon-estrin semyon-estrin requested a review from a team as a code owner February 14, 2022 11:10
@semyon-estrin semyon-estrin self-assigned this Feb 14, 2022
@codeclimate
Copy link

codeclimate bot commented Feb 14, 2022

Code Climate has analyzed commit fa3419f and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.0%.

View more on Code Climate.

@@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [1.17.2] - 2022-02-13

### Fixed
- IAM Authn bug fix - Take rexml gem to production configuration [#2493](https://github.com/cyberark/conjur/pull/2493)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants