-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rack from 2.2.3 to 2.2.3.1 #2564
Conversation
af5f30a
to
d0e609e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependabot fix looks good. I added CHANGELOG entry. Rack is not in NOTICES.txt file.
I moved simplecov to a dev/test dependency which got the trivy scans past detecting rack inside simplecov too. |
Bumps [rack](https://github.com/rack/rack) from 2.2.3 to 2.2.3.1. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md) - [Commits](rack/rack@2.2.3...2.2.3.1) Signed-off-by: Andy Tinkham <[email protected]> --- updated-dependencies: - dependency-name: rack dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Andy Tinkham <[email protected]>
64f7cd1
to
d380560
Compare
@@ -12,10 +12,14 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
## [1.17.7] - 2022-05-19 | |||
|
|||
### Changed | |||
- Made simplecov a dev/test dependency | |||
[cyberark/conjur#2564](https://github.com/cyberark/conjur/pull/2564) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces
@@ -12,10 +12,14 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
## [1.17.7] - 2022-05-19 | |||
|
|||
### Changed | |||
- Made simplecov a dev/test dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lists should be surrounded by blank lines
- Added configuration for token TTL | ||
[cyberark/conjur#2510](https://github.com/cyberark/conjur/pull/2510) | ||
|
||
### Security | ||
- Update rack to 2.2.3.1 to resolve CVE-2022-3023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lists should be surrounded by blank lines
To support recent k8s versions
Code Climate has analyzed commit 5ce3110 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 89.8% (0.2% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @micahlee!
The `|| true` previously caused authn-k8s test errors to not fail the jenkins test stage. We fixed this for GKE in #2564. However, it was accidentally left in the OCP test script.
Bumps rack from 2.2.3 to 2.2.3.1. Also makes simplecov a dev dependency to avoid installing it in the shipping Conjur container (as simplecov-html pulls in a vulnerable version of rack and has no update currently available. Also, running Conjur should not require code coverage.)
Changelog
Sourced from rack's changelog.
... (truncated)
Commits
925a4a6
update changelog70c0a24
bump version434413f
Escape untrusted text when logginga872bcc
Restrict broken mime parsingDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.