Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds status support for V2 OIDC Authenticators #2692

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

jvanderhoof
Copy link
Contributor

@jvanderhoof jvanderhoof commented Dec 29, 2022

Desired Outcome

This commit adds support for checking a V2 authenticator configuration using the authenticator status endpoint. Previously, status was invalid because the required variables differ between version 1 and 2.

Implemented Changes

The change is intentionally hacky to minimize the size of the change. Most of the issue will be resolved when we add support for validating an OIDC JWT in V2. This will allow us to depreciate the V1 functionality.

Connected Issue/Story

CyberArk internal issue ID: ONYX-25531

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

This commit adds support for checking a V2 authenticator configuration
using the authenticator status endpoint. Previously, status was invalid
because the required variables differ between version 1 and 2.
@jvanderhoof jvanderhoof force-pushed the fix-oidc-v2-status-error branch from 2905dbe to 4fcd92a Compare December 29, 2022 18:43
@jvanderhoof jvanderhoof marked this pull request as ready for review December 29, 2022 18:44
@jvanderhoof jvanderhoof requested a review from a team as a code owner December 29, 2022 18:44
@codeclimate
Copy link

codeclimate bot commented Dec 29, 2022

Code Climate has analyzed commit 4fcd92a and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3

The test coverage on the diff in this pull request is 71.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.0% (-1.5% change).

View more on Code Climate.

Copy link
Contributor

@telday telday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvanderhoof jvanderhoof merged commit 7620097 into master Jan 4, 2023
@jvanderhoof jvanderhoof deleted the fix-oidc-v2-status-error branch January 4, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants