Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fix nightly FIPS tests in jenkins #2858

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

iperalta7
Copy link
Contributor

@iperalta7 iperalta7 commented Jul 12, 2023

Desired Outcome

Fix for failures in some of the nightly EE FIPS tests.docker compose is not being recognized in the pipeline specifically under the rehl executors. Docker-compose should instead be used when the system is on rehl since it uses an older docker version/and unable to run compose v2 syntax.

Implemented Changes

ENV variable now used to determine the system the executor is on. Docker-compose if on Red Hat Enterprise Linux otherwise just do Docker compose.

Connected Issue/Story

CyberArk internal issue ID: CNJR-2310

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@iperalta7 iperalta7 force-pushed the nightly-fips-tests branch from 0cb0115 to 2be1538 Compare July 12, 2023 16:40
@iperalta7 iperalta7 changed the title test jenkins Fix night FIPS tests in jenkins Jul 12, 2023
@iperalta7 iperalta7 changed the title Fix night FIPS tests in jenkins Test fix night FIPS tests in jenkins Jul 12, 2023
@iperalta7 iperalta7 changed the title Test fix night FIPS tests in jenkins Test fix nightly FIPS tests in jenkins Jul 12, 2023
@iperalta7 iperalta7 force-pushed the nightly-fips-tests branch from 2be1538 to 3ee5c67 Compare July 12, 2023 17:02
@iperalta7 iperalta7 closed this Jul 12, 2023
@iperalta7 iperalta7 force-pushed the nightly-fips-tests branch from 3ee5c67 to 2a25415 Compare July 12, 2023 17:50
@iperalta7 iperalta7 reopened this Jul 12, 2023
@iperalta7 iperalta7 force-pushed the nightly-fips-tests branch 8 times, most recently from 78c9b67 to b11cb84 Compare July 13, 2023 15:24
@codeclimate
Copy link

codeclimate bot commented Jul 13, 2023

Code Climate has analyzed commit b11cb84 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 87.2% (-1.0% change).

View more on Code Climate.

@iperalta7 iperalta7 force-pushed the nightly-fips-tests branch 4 times, most recently from 8190876 to f685382 Compare July 13, 2023 17:49
@iperalta7 iperalta7 marked this pull request as ready for review July 13, 2023 18:02
@iperalta7 iperalta7 requested a review from a team as a code owner July 13, 2023 18:02
@iperalta7 iperalta7 force-pushed the nightly-fips-tests branch from f685382 to 3c66f84 Compare July 13, 2023 18:34
@iperalta7 iperalta7 force-pushed the nightly-fips-tests branch from 3c66f84 to 00b1b5f Compare July 13, 2023 19:14
Copy link
Contributor

@codihuston codihuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@iperalta7 iperalta7 merged commit 3dc214c into master Jul 13, 2023
@iperalta7 iperalta7 deleted the nightly-fips-tests branch July 13, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants