Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding approval check marks to M1 design spec #346

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

diverdane
Copy link
Contributor

@diverdane diverdane commented Jul 21, 2021

What does this PR do?

Adds approval check marks for the M1 design spec. Folks have already approved informally, just need to get the check marks in to make it formal.

What ticket does this PR close?

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@diverdane diverdane self-assigned this Jul 21, 2021
@diverdane diverdane requested review from a team as code owners July 21, 2021 22:33
@diverdane diverdane force-pushed the add-m1-design-approvals branch from 518db77 to c517273 Compare July 21, 2021 22:38
Copy link
Contributor

@rpothier rpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diverdane diverdane merged commit 5073958 into main Jul 22, 2021
@diverdane diverdane deleted the add-m1-design-approvals branch August 13, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants