Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding initial directories for push to file #358

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Sep 2, 2021

What does this PR do?

This lays out the initial file structure for push to file.

What ticket does this PR close?

Resolves #342

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@rpothier rpothier requested review from a team as code owners September 2, 2021 13:35
@rpothier rpothier force-pushed the 384_m1_project_layout branch from 852ebff to d79055e Compare September 2, 2021 13:37
@codeclimate
Copy link

codeclimate bot commented Sep 2, 2021

Code Climate has analyzed commit d79055e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 87.5% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting the ball rolling on this project structure!
I think what we can do to get this merged as a placeholder is:

This directory will be used to define a package for the Secrets Provider "Push to File" functionality. It will contain source code to do the following:

  • Parse the keys used in push-to-file annotations (e.g. sort annotations based on secrets group)
  • Retrieve Conjur secrets for each secrets group and write retrieved values to a file info data struct
  • Write secrets files to a shared volume

...and...

This directory will be used to define a package that provides generic parsing of Annotations files that have been created by Kubernetes via the Kubernetes Downward API. This package will read in files that contain entries of the form <key>=<value>, and will create a Golang map of the form map[string]string.

@rpothier rpothier force-pushed the 384_m1_project_layout branch 2 times, most recently from d68b959 to 335cf54 Compare September 7, 2021 20:54
@rpothier rpothier force-pushed the 384_m1_project_layout branch from 335cf54 to c00c5c8 Compare September 7, 2021 20:59
Copy link
Contributor

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

There is a defined project structure for M1 push to file
2 participants