Configure Authn client with annotations #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-odonnell
force-pushed
the
ONYX-11828
branch
5 times, most recently
from
dc38906 to
93fb297
Compare
john-odonnell
force-pushed
the
ONYX-11828
branch
6 times, most recently
from
124bc7b to
aae0ead
Compare
|
Code Climate has analyzed commit aae0ead and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 92.6% (0.0% change). View more on Code Climate. |
john-odonnell
changed the title
diverdane
approved these changes
Oct 15, 2021
| @@ -24,3 +24,5 @@ const CSPFK009I string = "CSPFK009I DAP/Conjur Secrets updated in Kubernetes suc | |||
| const CSPFK010I string = "CSPFK010I Updating Kubernetes Secrets: %d retries out of %d" | |||
| const CSPFK011I string = "CSPFK011I Annotation '%s' valid, but not recognized" | |||
| const CSPFK012I string = "CSPFK012I Secrets Provider setting '%s' set by both environment variable '%s' and annotation '%s'" | |||
| const CSPFK013I string = "CSPFK013I Gathering settings for Authenticator client configuration..." | |||
| const CSPFK014I string = "CSPFK014I Authenticator setting %s provided by %s" | |||
There was a problem hiding this comment.
NICE! This will be very helpful knowing the source of config.
| log.Info(messages.CSPFK014I, key, "environment") | ||
| } | ||
|
|
||
| return os.Getenv(key) |
There was a problem hiding this comment.
This reminds me... At some point, we'll want to add UT for this main.go, and we'll probably want to use dependency injection for the os functions so we can test with a mock os.
This will included unreleased functionality allowing the authn client to be configured using arbitrary sources.
john-odonnell
force-pushed
the
ONYX-11828
branch
from
aae0ead to
7294e62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TODO
This PR updates the Authenticator client dependency from v0.19.1 to a recent unreleased commit, cyberark/conjur-authn-k8s-client@5ca2371, in order to use unreleased functionality. Eventually,
go.modandgo.sumshould point to the next authn client release to include these changes.Configures the K8s authenticator with annotations using new functions implemented in cyberark/conjur-authn-k8s-client#407.
What ticket does this PR close?
ONYX-11828
Resolves #340
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or