Fix SecretGroup common policy path #392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
From ONYX-14902:
When the annotation
conjur.org/conjur-secrets-policy-path.{secret-group}
is set, it defines a common policy path prefix, assumed to be relative to the root policy. Policy paths defined inconjur.org/conjur-secrets.{secret-group}
are relative to this common path.When the annotation is not set, the policy paths defined in
conjur.org/conjur-secrets.{secret-group}
are themselves relative to the root policy.Implemented Changes
newSecretGroup
constructs a newSecretGroup
sg
, then makes a call tosg.resolveSecretSpecs()
.conjur.org/conjur-secret-policy-path.{secret-group}
, then theSecretSpecs
field is replaced by a copy of itself, with all secret paths being prepended with the common policy path.SecretSpecs
is assumed to contain fully-qualified policy paths to Conjur secrets, and it not updated.secret_group_test.go
PUSH_TO_FILE.md
updated to describeconjur.org/conjur-secret-policy-path.{secret-group}
annotation. Included an example to show two functionally identical annotation sets, one with a common policy prefix, and one without.Connected Issue/Story
CyberArk internal issue link: ONYX-14092
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security