Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONYX-16318: Add annotation for JWT TOKEN PATH #433

Merged
merged 1 commit into from
Feb 4, 2022
Merged

ONYX-16318: Add annotation for JWT TOKEN PATH #433

merged 1 commit into from
Feb 4, 2022

Conversation

tzheleznyak
Copy link
Contributor

Added annotation for JWT token path

Ticket : ONYX-16318

@tzheleznyak tzheleznyak requested review from szh and diverdane February 4, 2022 00:02
@tzheleznyak tzheleznyak requested a review from a team as a code owner February 4, 2022 00:02
@szh
Copy link
Contributor

szh commented Feb 4, 2022

This will still allow this to be configured via environment variable as well, correct?

szh
szh suggested changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to add this here as well.

@tzheleznyak
Copy link
Contributor Author

This will still allow this to be configured via environment variable as well, correct?

yes

@tzheleznyak tzheleznyak force-pushed the jwt-token-path-annotation branch from 550fb55 to 38e6df7 Compare February 4, 2022 14:34
@codeclimate
Copy link

codeclimate bot commented Feb 4, 2022

Code Climate has analyzed commit 38e6df7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.6% (0.0% change).

View more on Code Climate.

szh
szh approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tzheleznyak tzheleznyak merged commit dddff56 into main Feb 4, 2022
@szh szh deleted the jwt-token-path-annotation branch February 15, 2022 18:02
@john-odonnell john-odonnell mentioned this pull request May 17, 2022
Merged
@gl-johnson gl-johnson mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szh szh szh approved these changes

@diverdane diverdane Awaiting requested review from diverdane

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzheleznyak @szh