Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform sdk to 2.23.0 and forced latest golang.org/x/net #109

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

andytinkham
Copy link
Contributor

Signed-off-by: Andy Tinkham [email protected]

Desired Outcome

Remove versions of golang.org/x/net that are vulnerable to CVE-2022-27664

Implemented Changes

  • Updated github.com/hashicorp/terraform-provider-sdk to v2.23.0
  • Updated existing replace statements for golang.org/x/net to point to v0.0.0-20220923203811-8be639271d50
  • Added additional replace statement for version not previously replaced

Connected Issue/Story

CyberArk internal issue link: CONJSE-1533

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@andytinkham andytinkham requested a review from a team as a code owner September 26, 2022 18:07
Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you also update the license in NOTICES.txt with the new terraform-plugin-sdk version?

@andytinkham
Copy link
Contributor Author

Looks good, but can you also update the license in NOTICES.txt with the new terraform-plugin-sdk version?

Done. Thanks!

Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andytinkham andytinkham merged commit 7bb3994 into main Sep 26, 2022
@andytinkham andytinkham deleted the update-golang.org/x/net branch September 26, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants