Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.5.0 #80

Merged
merged 1 commit into from
May 6, 2021
Merged

Bump version to 0.5.0 #80

merged 1 commit into from
May 6, 2021

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented May 5, 2021

What does this PR do?

Updates the CHANGELOG.md and VERSION file ot 0.5.0

What ticket does this PR close?

Resolves
Works towards #79

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@rpothier rpothier requested a review from a team as a code owner May 5, 2021 18:55
CHANGELOG.md Outdated
@@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [0.5.0] - 2021-05-04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang, the date needs to be changed since I took so long to review this. :)

CHANGELOG.md Outdated
@@ -45,7 +46,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Initial release
- Use https://github.com/cyberark/conjur-api-go to read configuration.

[Unreleased]: https://github.com/cyberark/terraform-provider-conjur/compare/v0.4.0...HEAD
[Unreleased]: https://github.com/cyberark/terraform-provider-conjur/compare/v0.5.0...HEAD
[0.5.0]: https://github.com/cyberark/terraform-provider-conjur/compare/v0.4.0...v0.5.0
[0.4.0]: https://github.com/cyberark/terraform-provider-conjur/compare/v0.3.0...v0.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is outside of your change, but this line is using the wrong compare. It should reference v0.3.1 instead of v0.3.0:

[0.4.0]: https://github.com/cyberark/terraform-provider-conjur/compare/v0.3.1...v0.4.0

@rpothier rpothier force-pushed the 79-bump-version branch from 2ef22ac to 2e26ff6 Compare May 6, 2021 18:39
Copy link
Contributor

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poifect!

@rpothier rpothier merged commit 45af5cd into master May 6, 2021
@rpothier rpothier deleted the 79-bump-version branch May 6, 2021 18:52
@rpothier rpothier self-assigned this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants