Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore tiago and epuck_tools tests #641

Merged
merged 6 commits into from
Feb 24, 2023
Merged

Restore tiago and epuck_tools tests #641

merged 6 commits into from
Feb 24, 2023

Conversation

ygoumaz
Copy link
Contributor

@ygoumaz ygoumaz commented Feb 23, 2023

The e-puck_with_tools test is requiring RViz, but doesn't seem to crash in the CI (unlike turtlebot ones).

The Tiago test was disabled, because nav2_bringup was not available on Humble.

@ygoumaz ygoumaz added this to the 2023.0.3 milestone Feb 23, 2023
@ygoumaz ygoumaz self-assigned this Feb 23, 2023
@ygoumaz ygoumaz marked this pull request as ready for review February 23, 2023 15:49
@ygoumaz ygoumaz requested a review from ad-daniel February 24, 2023 07:52
ad-daniel
ad-daniel approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ygoumaz ygoumaz merged commit ca9349d into master Feb 24, 2023
@ygoumaz ygoumaz deleted the fix-restore-tiago-epuck-tests branch February 24, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad-daniel ad-daniel ad-daniel approved these changes

Assignees

@ygoumaz ygoumaz

Labels
None yet
Milestone
2023.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ygoumaz @ad-daniel