Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crazyflie webots packages #872

Merged
merged 9 commits into from
Jan 3, 2024

Conversation

knmcguire
Copy link
Contributor

@knmcguire knmcguire commented Dec 7, 2023

Description
This adds the Crazyflie to the ROS2 distribution of webots

Related Issues
This will mostly fix an external issue namely bitcraze/crazyflie-simulation#49

Affected Packages
None, it will just add a new one namely webots_ros2_crazyflie

Tasks
These are still remaining tasks or mostly questions before the pull request can be considered mergable

  • Documentation, adding some kind of tutorial.
  • Make launch file for a more complete example (teleop, mapping, rviz)

Update: The tutorial will be done on the ROS documentation once the binary is available. The more complex example will be added later

Additional context
Here are some questions for those reviewing this PR

  • Documentation, is indeed this in the wiki or not? Or is it okay if we make a tutorial on our on our own website?
  • I'd like to show this working with the simple_mapper but the standard map_size is too small. Perhaps I can add that as a seperate PR to make this determine on a parameter, and add an update to this package afterwards.

@omichel omichel self-requested a review December 19, 2023 13:25
@omichel omichel added the enhancement New feature or request label Dec 19, 2023
@omichel
Copy link
Member

omichel commented Dec 19, 2023

Sorry for my late answer, I missed your post on Discord.

That's perfectly fine if you make a tutorial on your own website. However, I would recommend making a tutorial directly on the official ROS 2 documentation as it will have a much better impact. Maybe you could create a subsection in this section: https://docs.ros.org/en/iron/Tutorials/Advanced/Simulators/Webots/Simulation-Webots.html (do you see the "Edit on GitHub" link?).

It is OK to make a more complete example later on. However, this PR should be self-sufficient, e.g., it should provide something useful to the user, without any missing component. But I believe it is the case, isn't it?

@knmcguire
Copy link
Contributor Author

No worries :) there is not a hurry on it and I see I need to fix quite a lot of CI issues anyway.

Ah yes that might an even better option to add it to ROS documentation. I was looking for an alternative for the wiki on the github repo that now currently exist but is a bit invisible.

The current example is already useful in the way that it is controllable by teleop twist and it outputs scans and a transform. for the more complex example that I wanted to include already is to connect this to the simple mapper that was made for the epuck, but I hit some issues with that along the way when I tried to combine the two. But perhaps this is already a big enough PR as is and I can contribute the complex example later.

I'll fix the CI issues next week and mark it as ready for review then.

@knmcguire
Copy link
Contributor Author

knmcguire commented Jan 3, 2024

Ah seems like the CI's pass now after a rerun, except for one on which both develop and master is failing on themselves, but that doesn't have anything to do with my PR.

I'll mark it ready for review now!

@knmcguire knmcguire marked this pull request as ready for review January 3, 2024 12:52
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
It looks very good to me.
I only have a few minor comments.

@knmcguire
Copy link
Contributor Author

Just a small thing that I noticed. Current the crazyflie's position is at approx (-5,-3) meters but I notice when I reset the simulator, the crazyflie is at (0,0), so a full reload is required. This seems to happen with webots without any involvement of ROS already... I'll see if I can investigate what is going on and report it for webots as an issue

@omichel omichel self-requested a review January 3, 2024 13:59
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@knmcguire
Copy link
Contributor Author

Thanks! I'll merge. I've made an issue for the webots issue I've mentioned before: cyberbotics/webots#6467

Also depended on when the package is released I'll make a tutorial in ROS documentation.

@knmcguire knmcguire merged commit 8c03af2 into cyberbotics:develop Jan 3, 2024
6 of 7 checks passed
@knmcguire knmcguire deleted the add-crazyflie-ros2 branch January 3, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants