Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at adapting T-Beam to AXP2101 #991

Closed
wants to merge 2 commits into from

Conversation

dirkbeer
Copy link

I'm not a programmer, but this does get the T-Beam with the new AXP2101 working. It senses devices and successfully uplinks packets to Helium. There are probably some functions that are not yet working correctly.

@cyberman54 cyberman54 changed the base branch from master to delevopment October 31, 2023 18:20
@cyberman54 cyberman54 marked this pull request as draft October 31, 2023 18:21
@cyberman54
Copy link
Owner

@dirkbeer Thanks for the PR! With this changes the AXP192 won't be supported any more. That's not what we want to achieve, we want backward compatibility. We need a device agnostic approach, e.g. detect chip at first, then select appropriate chip driver.

@dirkbeer
Copy link
Author

Understood. If I find some time, I'll work on a better implementation.

@cyberman54 cyberman54 deleted the branch cyberman54:development January 5, 2024 19:11
@cyberman54 cyberman54 closed this Jan 5, 2024
@cyberman54 cyberman54 reopened this Jan 5, 2024
@cyberman54 cyberman54 deleted the branch cyberman54:development January 5, 2024 19:25
@cyberman54 cyberman54 closed this Jan 5, 2024
@TD-er
Copy link
Contributor

TD-er commented Jun 10, 2024

@cyberman54 I do have boards with the AXP2101 and the previous AXP192.

Not sure yet if we can detect it properly at boot, but would it also be OK if we added a new board definition for the 1.2 revision?
Then the defines can be set to either add code for the AXP192 or the AXP2101.

@cyberman54
Copy link
Owner

Sure! You're welcome to create a PR on this. I assume chiptype should be identifyable by the used Xpowers library.

@cyberman54 cyberman54 reopened this Jun 10, 2024
@TD-er
Copy link
Contributor

TD-er commented Jun 10, 2024

I will look into this, but I will create my own PR for it, so you can keep this one closed I guess :)

Also I am struggling with the AXP192 on the T-beam 1.0, but will open another issue about it.

@cyberman54 cyberman54 closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants