Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade tfhe-rs to v0.10.0 and adopt breaking changes #1

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

moven0831
Copy link
Contributor

The main focus of these changes is to replace the bincode serialization library with tfhe::safe_serialization for secure serialization and deserialization of Fully Homomorphic Encryption (FHE) keys and related data structures.

Serialization and Deserialization Updates:

  • Replaced bincode with tfhe::safe_serialization for serialization and deserialization of FHE keys in call.rs, fhe_key.rs, genesis.rs, mock_decryption.rs, and token.rs. This includes updating functions to use safe_serialize and safe_deserialize with a maximum buffer size of 1 GB. [1] [2] [3] [4] [5]

Dependency Updates:

  • Updated the tfhe dependency version from 0.7.2 to 0.10.0 in Cargo.toml files to ensure compatibility with the new serialization methods.
  • Removed bincode from dependencies in Cargo.toml and various source files where it was previously used. [1] [2] [3] [4]

Code Cleanup:

  • Removed unused imports such as borsh and anyhow::Context from token.rs and utils.rs for cleaner and more maintainable code. [1] [2] [3]

These changes improve the security and maintainability of the codebase by adopting safer serialization methods and cleaning up unnecessary dependencies.

@moven0831 moven0831 requested a review from Zombieliu January 1, 2025 09:20
Copy link

github-actions bot commented Jan 1, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@moven0831
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@moven0831 moven0831 force-pushed the feat/confidential-token branch from d3a4601 to df28121 Compare January 1, 2025 09:46
@moven0831 moven0831 merged commit 47e3137 into feat/confidential-token Jan 2, 2025
1 check failed
@moven0831 moven0831 deleted the upgrade/tfhe branch January 2, 2025 01:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant