Merge pull request emberjs#16562 from bekzod/cleanup-component

correct conditionals in `component`
cyk · May 17, 2018 · 2d6579a · 2d6579a
2 parents ff5cf32 + 544cc64
commit 2d6579a
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/packages/ember-glimmer/lib/component.ts b/packages/ember-glimmer/lib/component.ts
@@ -602,12 +602,10 @@ const Component = CoreView.extend(
       }
 
       let args = this[ARGS];
-      let reference = args && args[key];
+      let reference = args !== undefined ? args[key] : undefined;
 
-      if (reference) {
-        if (reference[UPDATE]) {
-          reference[UPDATE](get(this, key));
-        }
+      if (reference !== undefined && reference[UPDATE] !== undefined) {
+        reference[UPDATE](get(this, key));
       }
     },
 
@@ -653,13 +651,10 @@ const Component = CoreView.extend(
       let isSVG = element.namespaceURI === SVG_NAMESPACE;
       let { type, normalized } = normalizeProperty(element, name);
 
-      if (isSVG) {
+      if (isSVG || type === 'attr') {
         return element.getAttribute(normalized);
       }
 
-      if (type === 'attr') {
-        return element.getAttribute(normalized);
-      }
       return element[normalized];
     },