enable eslint for entire repo and clean up revealed messes

.eslintrc-browser.js

@@ -0,0 +1,46 @@
+module.exports = {
+  root: true,
+  parserOptions: {
+    ecmaVersion: 6,
+    sourceType: 'module',
+  },
+  extends: 'eslint:recommended',
+  plugins: [
+    "ember-internal"
+  ],
+  env: {
+    qunit: true,
+  },
+  globals: {
+    'expectAssertion': true,
+    'expectDeprecation': true,
+    'expectNoDeprecation': true,
+    'expectWarning': true,
+    'expectNoWarning': true,
+    'ignoreAssertion': true,
+    'ignoreDeprecation': true,
+
+    // A safe subset of "browser:true":
+    'window': true,
+    'document': true,
+    'setTimeout': true,
+    'clearTimeout': true,
+    'setInterval': true,
+    'clearInterval': true,
+    'console': true,
+
+    'Set': true,
+    'Symbol': true,
+    'WeakMap': true,
+  },
+  rules: {
+    'ember-internal/require-yuidoc-access': 'error',
+    'ember-internal/no-const-outside-module-scope': 'error',
+
+    'semi': 'error',
+
+    // temporarily disabled
+    'no-unused-vars': 'off',
+    'comma-dangle': 'off',
+  },
+};

.eslintrc-node.js

@@ -0,0 +1,20 @@
+module.exports = {
+  root: true,
+  parserOptions: {
+    ecmaVersion: 8,
+    sourceType: 'module',
+  },
+  extends: 'eslint:recommended',
+  plugins: [
+    "ember-internal"
+  ],
+  env: {
+    mocha: true,
+    node: true,
+    qunit: true
+  },
+  globals: {
+    Map: false,
+    Set: false
+  }
+};

.eslintrc.js

@@ -1,46 +1 @@
-module.exports = {
-  root: true,
-  parserOptions: {
-    ecmaVersion: 6,
-    sourceType: 'module',
-  },
-  extends: 'eslint:recommended',
-  plugins: [
-    "ember-internal"
-  ],
-  env: {
-    qunit: true,
-  },
-  globals: {
-    'expectAssertion': true,
-    'expectDeprecation': true,
-    'expectNoDeprecation': true,
-    'expectWarning': true,
-    'expectNoWarning': true,
-    'ignoreAssertion': true,
-    'ignoreDeprecation': true,
-
-    // A safe subset of "browser:true":
-    'window': true,
-    'document': true,
-    'setTimeout': true,
-    'clearTimeout': true,
-    'setInterval': true,
-    'clearInterval': true,
-    'console': true,
-
-    'Set': true,
-    'Symbol': true,
-    'WeakMap': true,
-  },
-  rules: {
-    'ember-internal/require-yuidoc-access': 'error',
-    'ember-internal/no-const-outside-module-scope': 'error',
-
-    'semi': 'error',
-
-    // temporarily disabled
-    'no-unused-vars': 'off',
-    'comma-dangle': 'off',
-  },
-};
+module.exports = require('./.eslintrc-node');

.travis.yml

@@ -66,3 +66,4 @@ env:
     - TEST_SUITE=blueprints
     - TEST_SUITE=travis-browsers DISABLE_JSCS=true DISABLE_JSHINT=true
     - TEST_SUITE=each-package-tests BUILD_TYPE=alpha PUBLISH=true
+

bin/feature-flag-yuidoc-filter.js

@@ -49,7 +49,7 @@ function updateClassReferencesInNamespaces(data) {
   }
 }
 
-module.exports = function (data, options) {
+module.exports = function (data) {
   var featuresToFilter = gatherFeatures();
   data.classes = gatherClassesToDocument(data, featuresToFilter);
   updateClassReferencesInNamespaces(data);

bin/run-node-tests.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+/* eslint-disable no-console */
+
 global.QUnit = require('qunitjs');
 
 // Adds test reporting.

bin/run-sauce-tests.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+/* eslint-disable no-console */
+
 var RSVP  = require('rsvp');
 var spawn = require('child_process').spawn;
 

bin/run-tests.js

@@ -1,7 +1,8 @@
 #!/usr/bin/env node
 
+/* eslint-disable no-console */
+
 var RSVP  = require('rsvp');
-var spawn = require('child_process').spawn;
 var chalk = require('chalk');
 var FEATURES = require('../broccoli/features');
 var getPackages = require('../lib/packages');
@@ -40,6 +41,9 @@ function runInBrowser(url, retries, resolve, reject) {
 
   puppeteer.launch().then(function(browser) {
     browser.newPage().then(function(page) {
+      /* globals window */
+      var crashed;
+
       page.on('console', function(msg) {
         console.log(msg.text);
 
@@ -131,15 +135,13 @@ function runInBrowser(url, retries, resolve, reject) {
       page.exposeFunction('callPhantom', function(message) {
         if (message && message.name === 'QUnit.done') {
           result = message.data;
-          failed = !result || !result.total || result.failed;
+          var failed = !result || !result.total || result.failed;
 
           if (!result.total) {
             console.error('No tests were executed. Are you loading tests asynchronously?');
           }
 
           var code = failed ? 1 : 0;
-          var crashed = false;
-
           result.code = code;
 
           if (!crashed && code === 0) {
@@ -245,21 +247,24 @@ switch (process.env.TEST_SUITE) {
   case 'node':
     console.log('suite: node');
     require('./run-node-tests');
-    return;
+    process.exit(0);
+    break;
   case 'blueprints':
     console.log('suite: blueprints');
     require('../node-tests/nodetest-runner');
     server.close();
-    return;
+    process.exit(0);
+    break;
   case 'travis-browsers':
     console.log('suite: travis-browsers');
     require('./run-travis-browser-tests');
-    return;
-
+    process.exit(0);
+    break;
   case 'sauce':
     console.log('suite: sauce');
     require('./run-sauce-tests');
-    return;
+    process.exit(0);
+    break;
   default:
     console.log('suite: default (generate each package)');
     generateEachPackageTests();

bin/run-travis-browser-tests.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+/* eslint-disable no-console */
+
 var RSVP  = require('rsvp');
 var spawn = require('child_process').spawn;
 

blueprints/-addon-import.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 var stringUtil  = require('ember-cli-string-utils');
 var path        = require('path');
 var inflector   = require('inflection');

blueprints/acceptance-test/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const path = require('path');
 const testInfo = require('ember-cli-test-info');
 const pathUtil = require('ember-cli-path-utils');

blueprints/component-addon/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const path = require('path');
 const stringUtil = require('ember-cli-string-utils');
 const validComponentName = require('ember-cli-valid-component-name');

blueprints/component-test/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const path = require('path');
 const testInfo = require('ember-cli-test-info');
 const stringUtil = require('ember-cli-string-utils');

blueprints/component/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const path = require('path');
 const stringUtil = require('ember-cli-string-utils');
 const pathUtil = require('ember-cli-path-utils');

blueprints/controller-test/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const stringUtil = require('ember-cli-string-utils');
 const testInfo = require('ember-cli-test-info');
 

blueprints/controller/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 module.exports = {
   description: 'Generates a controller.'
 };

blueprints/helper-addon/index.js

@@ -1,5 +1,3 @@
 'use strict';
 
-/* eslint-env node */
-
 module.exports = require('../-addon-import');

blueprints/helper-test/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const testInfo = require('ember-cli-test-info');
 const stringUtils = require('ember-cli-string-utils');
 const isPackageMissing = require('ember-cli-is-package-missing');

blueprints/helper/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const normalizeEntityName = require('ember-cli-normalize-entity-name');
 
 module.exports = {

blueprints/initializer-addon/index.js

@@ -1,5 +1,3 @@
 'use strict';
 
-/* eslint-env node */
-
 module.exports = require('../-addon-import');

blueprints/initializer-test/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const testInfo = require('ember-cli-test-info');
 const stringUtils = require('ember-cli-string-utils');
 

blueprints/initializer/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 module.exports = {
   description: 'Generates an initializer.'
 };

blueprints/instance-initializer-addon/index.js

@@ -1,5 +1,3 @@
 'use strict';
 
-/* eslint-env node */
-
 module.exports = require('../-addon-import');

blueprints/instance-initializer-test/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const testInfo = require('ember-cli-test-info');
 const stringUtils = require('ember-cli-string-utils');
 

blueprints/instance-initializer/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 module.exports = {
   description: 'Generates an instance initializer.'
 };

blueprints/mixin-test/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const testInfo = require('ember-cli-test-info');
 const useTestFrameworkDetector = require('../test-framework-detector');
 

blueprints/mixin/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 module.exports = {
   description: 'Generates a mixin.'
 };

blueprints/route-addon/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const path = require('path');
 const stringUtil = require('ember-cli-string-utils');
 const inflector = require('inflection');

blueprints/route-test/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const testInfo = require('ember-cli-test-info');
 const path = require('path');
 const stringUtil = require('ember-cli-string-utils');

blueprints/route/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const fs = require('fs');
 const path = require('path');
 const chalk = require('chalk');

blueprints/service-test/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 const testInfo = require('ember-cli-test-info');
 
 const useTestFrameworkDetector = require('../test-framework-detector');

blueprints/service/index.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-env node */
-
 module.exports = {
   description: 'Generates a service.'
 };